Skips Namespace deletion on installlerSet deletion #565
Conversation
Previoulsy, if we delete an installerSet with Namespace eg pipelines it would delete ns too which means it would delete resources from other installerSet and the other installerSet will try to recreate it. so it might corrupt the resources. this update the installerSet to skip the deletion and update the owner of namespace to the owner of installerSet which means namespace will be deleted when TektonPipeline CR is deleted and not when its installerSet is deleted. this also updates the deletion flow in finalizer of TektonConfig. delete the resources in the reverse way of deletion. so delete platform specific first then triggers and then pipelines. Signed-off-by: Shivam Mukhade <[email protected]>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
|
The following is the coverage report on the affected files.
|
| if original.Spec.Profile == v1alpha1.ProfileLite { | ||
| return pipeline.TektonPipelineCRDelete(ctx, r.operatorClientSet.OperatorV1alpha1().TektonPipelines(), v1alpha1.PipelineResourceName) | ||
| } else { | ||
| // TektonPipeline and TektonTrigger is common for profile type basic and all | ||
| if err := pipeline.TektonPipelineCRDelete(ctx, r.operatorClientSet.OperatorV1alpha1().TektonPipelines(), v1alpha1.PipelineResourceName); err != nil { | ||
| if err := trigger.TektonTriggerCRDelete(ctx, r.operatorClientSet.OperatorV1alpha1().TektonTriggers(), v1alpha1.TriggerResourceName); err != nil { |
There was a problem hiding this comment.
Why do we need this change 🤔
There was a problem hiding this comment.
we need to delete in the reverse order of resource creation
as deleting TektonPipeline will delete namespace
we delete dashboard, triggers and then pipelines
just to make all resource get deleted in a cleaner way
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Previoulsy, if we delete an installerSet with Namespace eg pipelines
it would delete ns too which means it would delete resources from other
installerSet and the other installerSet will try to recreate it. so it
might corrupt the resources.
this update the installerSet to skip the deletion and update the owner of namespace to
the owner of installerSet which means namespace will be deleted when TektonPipeline CR
is deleted and not when its installerSet is deleted.
this also updates the deletion flow in finalizer of TektonConfig.
delete the resources in the reverse way of creation.
so delete platform specific first then triggers and then pipelines.
Signed-off-by: Shivam Mukhade [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes